[Autocomplete] Fix tag removal regression #36116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
bug 🐛
1 task
Netlify deploy previewNo updates. Bundle size report |
| ) { | ||
| const previousHighlightedOption = previousProps.filteredOptions[highlightedIndexRef.current]; | ||
|
|
||
| if (previousHighlightedOption) { | ||
| const previousHighlightedOptionExists = filteredOptions.some((option) => { | ||
| return getOptionLabel(option) === getOptionLabel(previousHighlightedOption); | ||
| return isOptionEqualToValue(option, previousHighlightedOption); |
There was a problem hiding this comment.
Ah, ok. We could use something similar to optionComparer from Base's useListbox:
But then introducing yet another prop looks like an overkill. I'll leave just the bare minimum to fix the issue here, and we can discuss the approach for changing
getOptionLabel elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the regression introduced in #35735 and described in #36114.
It makes sure the options that are compared exist.
Before: https://codesandbox.io/s/recursing-snyder-ybg6m5?file=/demo.tsx
After: https://codesandbox.io/s/hardcore-einstein-yx1xwr?file=/demo.tsx
(see the linked issue for repro steps)
Fixes #36114.