[core] Add default preview url #36118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36118--material-ui.netlify.app/ Bundle size report |
siriwatknp
commented
Feb 9, 2023
oliviertassinari
approved these changes
Feb 10, 2023
| const asPathWithoutLang = router.asPath.replace(/^\/[a-zA-Z]{2}\//, '/'); | ||
| let product = asPathWithoutLang.replace(/^\/([^/]+)\/.*/, '$1'); | ||
|
|
||
| const asPathWithoutLang = router.asPath.replace(/^\/+[a-zA-Z]{2}\//, '/'); |
There was a problem hiding this comment.
We usually do this in the rest of the codebase.
Would it make sense to do
Suggested change
| const asPathWithoutLang = router.asPath.replace(/^\/+[a-zA-Z]{2}\//, '/'); | |
| const { canonicalAs: asPathWithoutLang } = pathnameToLanguage(router.asPath); |
And fix
const canonicalAs = userLanguage === 'en' ? pathname : pathname.substring(3);?
There was a problem hiding this comment.
For this, I will open another PR to refactor the code and add more tests.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Even if there is no docs change, the preview URL should show.
After: