Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppBar] Fix joinVars() not handling undefined #36128

Merged
merged 1 commit into from
Feb 13, 2023
Merged

[AppBar] Fix joinVars() not handling undefined #36128

merged 1 commit into from
Feb 13, 2023

Conversation

donaldnevermore
Copy link
Contributor

@donaldnevermore donaldnevermore commented Feb 10, 2023 •
edited by siriwatknp

@mui-bot
Copy link

mui-bot commented Feb 10, 2023 •
edited

Netlify deploy preview

No updates.

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 43a617e

@zannager zannager added the component: app bar This is the name of the generic UI component, not the React module! label Feb 10, 2023
siriwatknp
siriwatknp approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your first contribution! look forward to the next one.

@siriwatknp siriwatknp merged commit ee9e128 into mui:master Feb 13, 2023
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work package: joy-ui Specific to @mui/joy labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@muhammedogz muhammedogz muhammedogz approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: app bar This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Material] [CssVars] --AppBar-color is invalid when dark color scheme is deleted
6 participants
@donaldnevermore @mui-bot @siriwatknp @muhammedogz @oliviertassinari @zannager