[docs] Fix modal transition demos #36137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
small-fixes-v14
branch
from
2f77c73
to
e90363a
Compare
Netlify deploy previewhttps://deploy-preview-36137--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
small-fixes-v14
branch
from
e90363a
to
ef3e011
Compare
oliviertassinari
force-pushed
the
small-fixes-v14
branch
from
ef3e011
to
723eff8
Compare
| @@ -65,11 +65,11 @@ function ChildModal() { | |||
| <React.Fragment> | |||
| <Button onClick={handleOpen}>Open Child Modal</Button> | |||
| <Modal | |||
| hideBackdrop | |||
There was a problem hiding this comment.
The UX is broken if we disable the backdrop.
I suspect this prop is here because we wanted to test that it was behaving correctly.
| TransitionComponent = Fade, | ||
| transitionDuration, |
There was a problem hiding this comment.
Sort props asc
| invisible = false, | ||
| open, | ||
| slotProps = {}, | ||
| slots = {}, | ||
| transitionDuration, | ||
| // eslint-disable-next-line react/prop-types |
There was a problem hiding this comment.
This is gone, we were missing the type for TransitionComponent.
| return typeof element === 'string'; | ||
| } | ||
|
|
||
| export default isHostComponent; |
Comment on lines
-35
to
-36
| BackdropComponent={Backdrop} | ||
| BackdropProps={{ |
There was a problem hiding this comment.
deprecated APIs
Comment on lines
+67
to
+80
| slots={{ backdrop: Backdrop }} | ||
| slotProps={{ | ||
| backdrop: { | ||
| TransitionComponent: Fade, | ||
| }, |
There was a problem hiding this comment.
For a consistent animation, use the Fade component for both the modal body and modal backdrop.
| } | ||
| }, | ||
| }); | ||
|
|
||
| return ( | ||
| <animated.div ref={ref} style={style} {...other}> | ||
| {children} | ||
| {React.cloneElement(children, { onClick })} |
There was a problem hiding this comment.
the click needs to be registered on the element that is position fixed to work.
oliviertassinari
force-pushed
the
small-fixes-v14
branch
from
723eff8
to
3a91549
Compare
oliviertassinari
force-pushed
the
small-fixes-v14
branch
from
3a91549
to
8c44bcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two demos in https://mui.com/base/react-modal/#transitions have broken animations. It feels all off.
I noticed this in #36023.
https://deploy-preview-36137--material-ui.netlify.app/base/react-modal/#transitions