[Joy] Select popup should have max-height #36156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Netlify deploy previewBundle size report |
hbjORbj
added
bug 🐛
|
Please run |
hbjORbj
changed the title
|
@Vivek-Prajapatii Thanks for opening the PR but I think you have to fix the implementation, not the demo file. |
siriwatknp
requested changes
Feb 13, 2023
This comment was marked as outdated.
This comment was marked as outdated.
|
@Vivek-Prajapatii you can add |
This comment was marked as outdated.
This comment was marked as outdated.
siriwatknp
reviewed
Feb 21, 2023
| minWidth: 'max-content', // prevent options from shrinking if some of them is wider than the Select's root. | ||
| maxHeight: 300, | ||
| overflow: 'auto', | ||
| width: 'max-content', // prevent options from shrinking if some of them is wider than the Select's root. |
There was a problem hiding this comment.
@Vivek-Prajapatii May I ask why minWidth is changed to width?
There was a problem hiding this comment.
width will be overridden by Popperjs, so it should be minWidth.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
siriwatknp
approved these changes
Feb 21, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Feb 22, 2023
siriwatknp
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Feb 24, 2023
| @@ -240,6 +241,8 @@ const SelectListbox = styled(StyledList, { | |||
| '--List-item-stickyTop': 'calc(var(--List-padding, var(--List-divider-gap)) * -1)', // negative amount of the List's padding block | |||
| ...scopedVariables, | |||
| minWidth: 'max-content', // prevent options from shrinking if some of them is wider than the Select's root. | |||
| maxHeight: '44vh', // the best value from what I tried so far which does not cause screen flicker when listbox is open. | |||
There was a problem hiding this comment.
IMHO we should take a lot more vertical space, Radix feels better on my 14" screen:
Same as macOS and Material UI:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36115