Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Badge][material] Replace BadgeUnstyled with useBadge hook #36158

Merged
merged 7 commits into from Feb 16, 2023

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Feb 13, 2023

Closes #36130
Solves part of #34502

Changes

  • Material Badge is implemented using BadgeUnstyled at the moment. It is replaced with useBadge hook in this PR since we want to implement design system components with hooks.

@hbjORbj hbjORbj changed the title [Badge] Replace BadgeUnstyled with useBadge hook [Badge][material] Replace BadgeUnstyled with useBadge hook Feb 13, 2023
@hbjORbj hbjORbj self-assigned this Feb 13, 2023
@hbjORbj hbjORbj added component: badge This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature labels Feb 13, 2023
@mui-bot
Copy link

mui-bot commented Feb 13, 2023

Netlify deploy preview

No updates.

@material-ui/core: parsed: -0.17% 😍, gzip: -0.13% 😍

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 5648bce

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be working well. Thanks!

@hbjORbj hbjORbj merged commit 8c74703 into mui:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: badge This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Badge] Implement using the useBadge hook
4 participants