Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Remove classes prop from the components that have it #36159

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Feb 13, 2023

Changes

  • Many Joy components still support classes prop. This PR drops the prop from these components.

It would be easier to merge this only after we merge #36008 to have less conflict

@hbjORbj hbjORbj self-assigned this Feb 13, 2023
@hbjORbj hbjORbj added package: joy-ui Specific to @mui/joy enhancement This is not a bug, nor a new feature labels Feb 13, 2023
@mui-bot
Copy link

mui-bot commented Feb 13, 2023

Netlify deploy preview

No updates.

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 9516b01

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch @hbjORbj

@hbjORbj hbjORbj merged commit dc11309 into mui:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants