[Grid][Stack] classNames prefixed with Mui #36167
Merged
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewNo updates. Bundle size report |
2 tasks
zannager
added
component: Grid
siriwatknp
approved these changes
Feb 14, 2023
There was a problem hiding this comment.
👍 Looks great @sai6855, thanks for the fix and the tests! I pushed a fix for the Box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes part of : #36082
tried changing classnames of Box from JoyBox-root to MuiBox-root but some existing tests were failing and i was bit spectical on changes introduced