Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Describe slotProps in MUI Base customization doc #36206

Merged
merged 14 commits into from
Apr 4, 2023
Merged

[docs] Describe slotProps in MUI Base customization doc #36206

merged 14 commits into from
Apr 4, 2023
+406 −8

Conversation

michaldudak
Copy link
Member

The MUI Base Customization doc doesn't mention slotProps. I added a section about it and another section at the bottom that helps choosing the customization option.

@michaldudak michaldudak added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Feb 15, 2023
@michaldudak michaldudak changed the title [docs] Describe slotProps in MUI Base customization [docs] Describe slotProps in MUI Base customization doc Feb 15, 2023
@mui-bot
Copy link

mui-bot commented Feb 15, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 8a32943

mapache-salvaje
mapache-salvaje reviewed Feb 21, 2023
View reviewed changes
@michaldudak @mapache-salvaje
Apply suggestions from code review
75245b8 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
@michaldudak
Copy link
Member Author

Thanks for the review guys. @samuelsycamore, what's your opinion on #36206 (comment)? I feel like describing all the options first and then providing guidance for the most popular styling solutions would read better especially if someone uses a styling solution that's not covered here.

@mj12albert
Copy link
Member

I feel like describing all the options first and then providing guidance for the most popular styling solutions would read better especially if someone uses a styling solution that's not covered here.

Let me add that the reasoning for my suggestion is that as a reader, "what option should I choose?" was the top question on my mind after reading "...several methods of customization..." in the introduction

@michaldudak michaldudak mentioned this pull request Feb 27, 2023
Merged
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 12, 2023
@michaldudak
Copy link
Member Author

All right, I moved this section to the top and reorganized the headers. Let me know what you think.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 12, 2023
mapache-salvaje
mapache-salvaje approved these changes Mar 25, 2023
View reviewed changes
Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🙌

@siriwatknp
Copy link
Member

@michaldudak I have fixed the docs:api in #36743. I will merge this one after that.

@michaldudak
Copy link
Member Author

OK, thanks a lot!

@siriwatknp siriwatknp merged commit 4ead1ea into mui:master Apr 4, 2023
@michaldudak michaldudak deleted the base-customization-docs-update branch April 4, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj12albert mj12albert

@mapache-salvaje mapache-salvaje

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michaldudak @mui-bot @mj12albert @siriwatknp @mapache-salvaje