[base] Move hooks to their own directories #36235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
hbjORbj
commented
Feb 19, 2023
| @@ -1,7 +1,8 @@ | |||
| import * as React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import clsx from 'clsx'; | |||
| import { useButton } from '@mui/base/ButtonUnstyled'; | |||
|
|
|||
There was a problem hiding this comment.
Running yarn docs:typescript:formatted creates this space. I don't know why 😅
There was a problem hiding this comment.
This could be interesting to investigate and debug (not necessarily in this PR, though) 😁
hbjORbj
commented
Feb 19, 2023
| @@ -1,6 +1,7 @@ | |||
| import * as React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import SelectUnstyled, { selectUnstyledClasses } from '@mui/base/SelectUnstyled'; | |||
|
|
|||
hbjORbj
commented
Feb 19, 2023
| @@ -1,6 +1,7 @@ | |||
| import * as React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import SelectUnstyled, { selectUnstyledClasses } from '@mui/base/SelectUnstyled'; | |||
|
|
|||
|
I found a few occurrences of the old paths in the docs left (FormControl, Input, Slider, Snackbar). Also, the API pages shows an incorrect import path of the hooks: (https://deploy-preview-36235--material-ui.netlify.app/base/api/use-button/) |
|
|
The useAutocomplete import is broken: https://deploy-preview-36235--material-ui.netlify.app/base/api/use-autocomplete/ |
|
My bad. Addressed it. |
hbjORbj
force-pushed
the
hook/directories
branch
from
6682c22
to
cc36ad5
Compare
michaldudak
approved these changes
Feb 21, 2023
1 task
siriwatknp
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Feb 24, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
useSelect) are no longer exported from{Component}Unstyleddirectories and instead they have their own directories.You can use this codemod to help with the migration.
Closes #34401
Closes #33903