-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Adds sx
prop to ListboxProps
type
#36243
Conversation
Netlify deploy previewhttps://deploy-preview-36243--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -42,6 +42,13 @@ function MyAutocomplete< | |||
renderInput={() => null} | |||
/>; | |||
|
|||
// Tests presence of sx prop in ListboxProps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added test name as it was not obvious what test is testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we apply the same fix in Joy UI's Autocomplete?
@mnajdova In joy csb: https://codesandbox.io/s/jolly-water-i58q4k?file=/demo.js |
sx
prop to ListboxPropssx
prop to ListboxProps type
sx
prop to ListboxProps typesx
prop to ListboxProps
type
closes : #36214
before: https://codesandbox.io/s/confident-worker-5ek4x8
after: https://codesandbox.io/s/friendly-montalcini-lt0s57?file=/demo.tsx