Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Adds sx prop to ListboxProps type #36243

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Feb 18, 2023

@mui-bot
Copy link

mui-bot commented Feb 18, 2023

Netlify deploy preview

https://deploy-preview-36243--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 7e867c1

@zannager zannager added the component: autocomplete This is the name of the generic UI component, not the React module! label Feb 20, 2023
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript labels Feb 21, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -42,6 +42,13 @@ function MyAutocomplete<
renderInput={() => null}
/>;

// Tests presence of sx prop in ListboxProps
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added test name as it was not obvious what test is testing

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we apply the same fix in Joy UI's Autocomplete?

@sai6855
Copy link
Contributor Author

sai6855 commented Feb 22, 2023

Should we apply the same fix in Joy UI's Autocomplete?

@mnajdova In joy Autocomplete sx prop is already added to listbox hence i didn't added.

csb: https://codesandbox.io/s/jolly-water-i58q4k?file=/demo.js

Screenshot 2023-02-22 at 12 59 25 PM

@sai6855 sai6855 requested review from mnajdova and removed request for michaldudak February 22, 2023 07:33
@ZeeshanTamboli ZeeshanTamboli changed the title [Autocomplete] Adds sx prop to ListboxProps [Autocomplete] Adds sx prop to ListboxProps type Feb 23, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [Autocomplete] Adds sx prop to ListboxProps type [Autocomplete] Adds sx prop to ListboxProps type Feb 23, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit a6d4d95 into mui:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type error when using sx in ListboxProps of Autocomplete
5 participants