Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix emotion warning :first-child #36263

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[docs] Fix emotion warning :first-child #36263

merged 1 commit into from
Feb 20, 2023

Conversation

siriwatknp
Copy link
Member

Regression from #36181 (comment)

@siriwatknp siriwatknp added docs Improvements or additions to the documentation regression A bug, but worse labels Feb 20, 2023
@siriwatknp siriwatknp mentioned this pull request Feb 20, 2023
Merged
1 task
@mui-bot
Copy link

mui-bot commented Feb 20, 2023 •
edited

Netlify deploy preview

https://deploy-preview-36263--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 529dc45

oliviertassinari
oliviertassinari approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 20, 2023 •
edited

The compat flag disables this warning, proof https://github.com/emotion-js/emotion/blob/f2608b3a542164a3622453f306e2b782929a3020/packages/cache/src/stylis-plugins.js#L161, as well as this CSS comment: emotion-js/emotion#1105 (comment) but I think that it's actually great that we see this warning, as developers might not extract the CSS from the <body> to the <head>.

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Feb 20, 2023
@siriwatknp siriwatknp merged commit 8d97d3d into mui:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siriwatknp @mui-bot @oliviertassinari