Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MenuUnstyled] Remove extra useMemo #36265

Merged
merged 3 commits into from
Feb 23, 2023

Conversation

ivp-dev
Copy link
Contributor

@ivp-dev ivp-dev commented Feb 20, 2023

@ivp-dev ivp-dev changed the title Remove extra useMemo from MenuUnstyled [base] Remove extra useMemo from MenuUnstyled Feb 20, 2023
@mui-bot
Copy link

mui-bot commented Feb 20, 2023

Netlify deploy preview

https://deploy-preview-36265--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against a384c48

@zannager zannager added the package: base-ui Specific to @mui/base label Feb 20, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 21, 2023
@ZeeshanTamboli ZeeshanTamboli added the component: menu This is the name of the generic UI component, not the React module! label Feb 22, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [base] Remove extra useMemo from MenuUnstyled [MenuUnstyled] Remove extra useMemo Feb 22, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Looks good. Can you update with the latest master branch and resolve the conflict?

@ivp-dev
Copy link
Contributor Author

ivp-dev commented Feb 22, 2023

Nice find! Looks good. Can you update with the latest master branch and resolve the conflict?

@ZeeshanTamboli done

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 22, 2023
@ivp-dev ivp-dev requested review from ZeeshanTamboli and removed request for michaldudak February 22, 2023 10:22
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 7cd2983 into mui:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants