Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add bundle size Toolpad app link to PRs #36311

Merged
merged 4 commits into from
Jun 29, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Feb 23, 2023

Add link to dogfooding bundle size Toolpad app for easier comparison.

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Feb 23, 2023
@mui-bot
Copy link

mui-bot commented Feb 23, 2023

Netlify deploy preview

https://deploy-preview-36311--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against bba6934

@Janpot Janpot marked this pull request as ready for review March 27, 2023 12:08
@zannager zannager requested a review from mnajdova March 28, 2023 10:21
@mnajdova
Copy link
Member

@Janpot should we update to latest master and try this? Is something preventing us from merging it from toolpad side?

@Janpot
Copy link
Member Author

Janpot commented Jun 21, 2023

@Janpot should we update to latest master and try this? Is something preventing us from merging it from toolpad side?

this is ready to be merged. we can update the pr to double check it's still working correctly.

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update to latest master before merging, to verify that something haven't broken in the mean time :)

@Janpot Janpot merged commit d47dd25 into mui:master Jun 29, 2023
18 checks passed
@Janpot Janpot deleted the tp-bundle-size-link branch June 29, 2023 09:13
@Janpot
Copy link
Member Author

Janpot commented Jun 29, 2023

Link works again after updating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants