Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Card] Fix Card focus effect overflowing parent card #36329

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Feb 25, 2023

Closes #36285

Fixes this in Safari:
Screenshot 2023-03-29 at 7 44 42 PM

Demo: mouseover the card here - https://deploy-preview-36329--material-ui.netlify.app/material-ui/react-card/#primary-action

Sorry, something went wrong.

@mj12albert mj12albert added component: card This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Feb 25, 2023
@mui-bot
Copy link

mui-bot commented Feb 25, 2023

Netlify deploy preview

https://deploy-preview-36329--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 75476d3

@mj12albert mj12albert marked this pull request as ready for review March 29, 2023 11:48
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch! I think it's worth adding a comment that link to the issue for this case.

Co-authored-by: Siriwat K <siriwatkunaporn@gmail.com>
Signed-off-by: Albert Yu <albert@albertyu.co>
@siriwatknp siriwatknp merged commit d24ac60 into mui:master Apr 4, 2023
@mj12albert mj12albert deleted the material/fix-safari-card-demo branch July 1, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: Safari component: card This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card outline when hovering/clicking in Safari is off.
3 participants