[Select] Make error part of the ownerState to enable overriding styles with it in theme
#36422
+166
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a custom theme for MuiSelect Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-36422--material-ui.netlify.app/ Bundle size report |
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
|
@siriwatknp this PR is ready for review |
zannager
added
the
component: select
2 tasks
ZeeshanTamboli
requested changes
Mar 23, 2023
There was a problem hiding this comment.
Select with error prop has a border color applied for error state. See https://codesandbox.io/s/falling-leaf-v6uuzt?file=/src/App.tsx.
While it does not work after changes in this PR, see https://codesandbox.io/s/material-cra-ts-forked-m06iu4?file=/src/App.tsx.
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
ownerState
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
|
Thanks for the review @ZeeshanTamboli, your feedback comment has been addressed. |
gitstart
requested review from
ZeeshanTamboli
and removed request for
siriwatknp
packages/mui-material/src/NativeSelect/NativeSelectInput.test.js
Outdated
Show resolved
Hide resolved
ZeeshanTamboli
changed the title
ownerStateownerState to enable overriding styles with it in theme
2 tasks
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
|
Your feedback comments have been addressed @ZeeshanTamboli, please check again. |
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
packages/mui-material/src/NativeSelect/NativeSelectInput.test.js
Outdated
Show resolved
Hide resolved
packages/mui-material/src/NativeSelect/NativeSelectInput.test.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
ZeeshanTamboli
approved these changes
Apr 3, 2023
|
@ZeeshanTamboli Thanks for the review rounds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #36269
This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.