-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Move styles to the bottom of demos code for Menu
#36582
Conversation
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@michaldudak this PR is ready for review |
Netlify deploy previewhttps://deploy-preview-36582--material-ui.netlify.app/ Bundle size report |
Menu
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good 👍 One note, please do not use close #XXX as it would actually close the issue, while not all demos are updated yet :)
@gitstart I am unable to push to your branch (getting access denied). Can you merge with the latest master branch to run the |
Done @ZeeshanTamboli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Part of #36498
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.