Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Move styles to the bottom of demos code for Menu #36582

Merged
merged 4 commits into from
Mar 31, 2023
Merged

[docs][base] Move styles to the bottom of demos code for Menu #36582

merged 4 commits into from
Mar 31, 2023

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Mar 20, 2023

Part of #36498


This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.

Sorry, something went wrong.

Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@gitstart gitstart marked this pull request as ready for review March 20, 2023 09:09
@gitstart
Copy link
Contributor Author

@michaldudak this PR is ready for review

@mui-bot
Copy link

mui-bot commented Mar 20, 2023

Netlify deploy preview

https://deploy-preview-36582--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against eac34c5

@zannager zannager added docs Improvements or additions to the documentation component: menu This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Mar 20, 2023
@zannager zannager requested a review from michaldudak March 20, 2023 10:21
@hbjORbj hbjORbj changed the title [MUI-36498] - [docs][base][Menu] Move styles to the bottom of demos code [docs][base] Move styles to the bottom of demos code for Menu Mar 20, 2023
gitstart and others added 2 commits March 22, 2023 10:35
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good 👍 One note, please do not use close #XXX as it would actually close the issue, while not all demos are updated yet :)

@ZeeshanTamboli
Copy link
Member

@gitstart I am unable to push to your branch (getting access denied). Can you merge with the latest master branch to run the ci/codesandbox build again so that we can merge the PR?

@gitstart
Copy link
Contributor Author

@gitstart I am unable to push to your branch (getting access denied). Can you merge with the latest master branch to run the ci/codesandbox build again so that we can merge the PR?

Done @ZeeshanTamboli

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ZeeshanTamboli ZeeshanTamboli merged commit d2d495c into mui:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: menu This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants