Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Move styles to the bottom of demos code for Snackbar #36719

Merged
merged 3 commits into from Apr 28, 2023

Conversation

varunmulay22
Copy link
Contributor

Part of #36498

@mui-bot
Copy link

mui-bot commented Mar 31, 2023

Netlify deploy preview

https://deploy-preview-36719--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 67cd936

@zannager zannager added the component: snackbar This is the name of the generic UI component, not the React module! label Mar 31, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title snackbar styles to the bottom [docs][base] Move styles to the bottom of demos code for Snackbar Apr 3, 2023
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Apr 3, 2023
@@ -2,6 +2,32 @@ import * as React from 'react';
import { styled, keyframes, css } from '@mui/system';
import SnackbarUnstyled from '@mui/base/SnackbarUnstyled';
import { SnackbarCloseReason } from '@mui/base/useSnackbar';
export default function UnstyledSnackbar() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default function UnstyledSnackbar() {
export default function UnstyledSnackbar() {

@@ -2,7 +2,36 @@ import * as React from 'react';
import useSnackbar from '@mui/base/useSnackbar';
import ClickAwayListener from '@mui/base/ClickAwayListener';
import { css, keyframes, styled } from '@mui/system';
export default function UseSnackbar() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default function UseSnackbar() {
export default function UseSnackbar() {

@@ -2,7 +2,36 @@ import * as React from 'react';
import useSnackbar from '@mui/base/useSnackbar';
import ClickAwayListener from '@mui/base/ClickAwayListener';
import { css, keyframes, styled } from '@mui/system';
export default function UseSnackbar() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default function UseSnackbar() {
export default function UseSnackbar() {

@michaldudak michaldudak merged commit 05bce52 into mui:master Apr 28, 2023
18 checks passed
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants