Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Move styles to the bottom of demos code for SliderUnstyled #36721

Merged
merged 3 commits into from Apr 28, 2023

Conversation

varunmulay22
Copy link
Contributor

Part of #36498

@mui-bot
Copy link

mui-bot commented Mar 31, 2023

Netlify deploy preview

https://deploy-preview-36721--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against f116797

@zannager zannager added the component: slider This is the name of the generic UI component, not the React module! label Mar 31, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title unstyled slider styles sent to bottom [docs][base] Move styles to the bottom of demos code for SliderUnstyled Apr 3, 2023
@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base labels Apr 3, 2023
return `${value}°C`;
}

export default function DiscreteSlider() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this first after the import statements.

return `${value}°C`;
}

export default function DiscreteSlider() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here x the others.

@michaldudak michaldudak merged commit 02c5fcc into mui:master Apr 28, 2023
18 checks passed
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
…yled` (mui#36721)

Co-authored-by: Michał Dudak <michal@dudak.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants