[docs] Remove hash property and leverage pathname #36764
Merged
+90
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36764--material-ui.netlify.app/ Bundle size report |
mnajdova
approved these changes
Apr 3, 2023
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@oliviertassinari found a bug from #35938
Preview: https://deploy-preview-36764--material-ui.netlify.app/base/react-tabs/hooks-api/#use-tab
Root cause
The
translations.jsondoes not contain the hash information, that's why the title are all the same.Fix
I don't think we need to add extra
hashproperty, instead push the hash to the pathname so that the title is generated correctly and we extract the hash before sending to NextJS Link.