[docs] Fix small regressions API pages #36972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Netlify deploy previewhttps://deploy-preview-36972--material-ui.netlify.app/ Bundle size report |
| @@ -305,7 +305,7 @@ export const getDesignTokens = (mode: 'light' | 'dark') => | |||
| fontWeight: 700, | |||
| }, | |||
| allVariants: { | |||
| scrollMarginTop: 'calc(var(--MuiDocs-header-height) + 72px)', | |||
| scrollMarginTop: 'calc(var(--MuiDocs-header-height) + 32px)', | |||
There was a problem hiding this comment.
Restore 32px, it's this distance:
It's always the same, even on the marketing pages which have a taller appbar than on the docs.
| @@ -4,7 +4,7 @@ import Container from '@mui/material/Container'; | |||
|
|
|||
| const StyledAppContainer = styled(Container)(({ theme }) => { | |||
| return { | |||
| paddingTop: 'calc(var(--MuiDocs-header-height) + 36px)', | |||
| paddingTop: `calc(var(--MuiDocs-header-height) + ${theme.spacing(4)})`, | |||
There was a problem hiding this comment.
for consistency with the other padding
| }, | ||
| }), | ||
| ...(hasTabs && { | ||
| '&& .component-tabs .MuiTabs-root': { | ||
| marginBottom: 193, | ||
| marginBottom: 198, |
There was a problem hiding this comment.
Fix #35938 (comment)
There is still a layout shift with Joy UI, but it's because the theme are not correctly isolated, the Ad renders with Joy UI theme, not with MUI's branding theme, a problem for another day.
| <Box> | ||
| <div | ||
| style={{ | ||
| '--MuiDocs-header-height': `${AppFrameHeight + TabsHeight}px`, |
There was a problem hiding this comment.
Fix #35938 (comment)
| @@ -111,6 +111,8 @@ const Root = styled('div')( | |||
| }, | |||
| '& h1, & h2, & h3, & h4': { | |||
| position: 'relative', | |||
| // Reserve space for the end of the line action button | |||
| paddingRight: 26 * 2 + 10, | |||
There was a problem hiding this comment.
Fix #35938 (comment)
| @@ -103,7 +103,7 @@ const pages = [ | |||
| ], | |||
| }, | |||
| { | |||
| title: 'Component API', | |||
| title: 'APIs', | |||
There was a problem hiding this comment.
Copied from #35938 (comment)
2 tasks
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few low-hanging fruits from the items left in #35938.