[docs] Handle a few docs-feedback #36977
Conversation
| <!-- TODO: revert this once it is migrated to v5 | ||
| - [Material Sense](https://github.com/alexanmtz/material-sense): | ||
|
|
||
| -  | ||
| - Graph using recharts | ||
| - React Router included with a navigation example | ||
| - A docker container with an Nginx server for production build | ||
| - Created with Create React App | ||
| --> |
There was a problem hiding this comment.
It's abandoned now.
| @@ -53,7 +53,12 @@ If you want to start with a more complete and real-world example, you could take | |||
| - All PWA features included (SW, Notifications, deferred installation prompt and more) | |||
| - Optimized and scalable performance (all ~100 points on Lighthouse) | |||
|
|
|||
| <!-- TODO: revert this once it is migrated to v5 | |||
There was a problem hiding this comment.
They migrated a year ago.
| @@ -27,7 +27,7 @@ const appList = [ | |||
| description: | |||
| 'QuintoAndar is a company that uses technology and ' + | |||
| 'design to simplify the rental of residential real estate.', | |||
| image: 'quintoandar.png', | |||
| image: 'quintoandar.jpg', | |||
There was a problem hiding this comment.
It was looking like crap, so redo a few screenshots, following a process close to https://www.notion.so/mui-org/Store-Screenshots-for-product-7a4cf2df5cb94389ab6adc80b6aeb054. We would need to retake all the screenshots, but since we might rework from scratch this page, I only did the first two.
https://mui.com/material-ui/discover-more/showcase/ burns my eye 🙃
| width="600" | ||
| height="450" |
There was a problem hiding this comment.
Fix layout shift when loading
| @@ -54,7 +54,7 @@ export default function Showcase() { | |||
| }; | |||
|
|
|||
| return ( | |||
| <Box sx={{ flexGrow: 1 }}> | |||
| <Box sx={{ flexGrow: 1, mx: [2, 0] }}> | |||
There was a problem hiding this comment.
It was broken on mobile, I think it was sending a red flag for designers that are considering using Material UI
| @@ -45,7 +45,7 @@ const sortFunctions = { | |||
| }; | |||
|
|
|||
| export default function Showcase() { | |||
| const [sortFunctionName, setSortFunctionName] = React.useState('dateAdded'); | |||
| const [sortFunctionName, setSortFunctionName] = React.useState('similarWebVisits'); | |||
There was a problem hiding this comment.
The traffic makes a lot more sense IMHO, it sends trust.
| ## Admin frameworks | ||
|
|
||
| - [React Admin](https://github.com/marmelab/react-admin): A frontend Framework for building data-driven applications running in the browser on top of REST/GraphQL APIs. |
There was a problem hiding this comment.
With https://mui.zendesk.com/agent/tickets/7593 we could add refine too.
| @@ -32,7 +32,7 @@ From now on, the `Grid` v1 and `Grid` v2 refer to the import as: | |||
|
|
|||
| ```js | |||
| import Grid from '@mui/material/Grid'; // Grid version 1 | |||
| import Grid2 from '@mui/material/Unstable_Grid2'; // Grid version 2 | |||
| import Grid from '@mui/material/Unstable_Grid2'; // Grid version 2 | |||
There was a problem hiding this comment.
For consistency with the text above. Reported in https://mui-org.slack.com/archives/C041SDSF32L/p1681137941293499.
|  | ||
|
|
||
| This package provides dialogs for confirming user actions without writing boilerplate code. | ||
| The package [`material-ui-confirm`](https://github.com/jonatanklosko/material-ui-confirm/) provides dialogs for confirming user actions without writing boilerplate code. |
There was a problem hiding this comment.
I have seen at least 3 people complain about this. It's hard to find the source. Proof:
- https://mui-org.slack.com/archives/C041SDSF32L/p1682203740409249
- https://mui-org.slack.com/archives/C041SDSF32L/p1681988333141769
- https://mui-org.slack.com/archives/C041SDSF32L/p1681232882180359
I think that we miss some kind of process for this to be prioritized, it seems to be a clear quick-win.
| @@ -41,7 +41,7 @@ It's possible to customize the control icons. | |||
|
|
|||
| ## Pagination ranges | |||
|
|
|||
| You can specify how many digits to display either side of current page with the `siblingRange` prop, and adjacent to the start and end page number with the `boundaryRange` prop. | |||
| You can specify how many digits to display either side of current page with the `siblingCount` prop, and adjacent to the start and end page number with the `boundaryCount` prop. | |||
There was a problem hiding this comment.
No description provided.