Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix template images not displayed #36991

Merged
merged 4 commits into from Apr 30, 2023
Merged

[docs] Fix template images not displayed #36991

merged 4 commits into from Apr 30, 2023

Conversation

navedqb
Copy link
Contributor

@navedqb navedqb commented Apr 24, 2023

Fixes #36988.

@navedqb
Added blog image.
08dcbd7 
Signed-off-by: navedqb <109583873+navedqb@users.noreply.github.com>
@navedqb
Added blog image.
ce50a82 
Signed-off-by: navedqb <109583873+navedqb@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Apr 24, 2023 •
edited

Netlify deploy preview

https://deploy-preview-36991--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 044d246

@navedqb
Checks fixed.
76f67e5 
Signed-off-by: navedqb <109583873+navedqb@users.noreply.github.com>
@navedqb
Checks fixed.
044d246 
Signed-off-by: navedqb <109583873+navedqb@users.noreply.github.com>
@zannager zannager added website Pages that are not documentation-related, marketing-focused. blog labels Apr 25, 2023
@michaldudak michaldudak changed the title [#36988] - Image not displayed in blog layout of React template. [templates] Image not displayed in blog layout of React template. Apr 26, 2023
@samuelsycamore samuelsycamore mentioned this pull request Apr 30, 2023
Closed
2 tasks
@samuelsycamore samuelsycamore added docs Improvements or additions to the documentation and removed website Pages that are not documentation-related, marketing-focused. blog labels Apr 30, 2023
@samuelsycamore samuelsycamore merged commit 1ed9f88 into mui:master Apr 30, 2023
23 checks passed
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 5, 2023
@oliviertassinari oliviertassinari changed the title [templates] Image not displayed in blog layout of React template. [docs] Fix template images not displayed May 5, 2023
@oliviertassinari oliviertassinari mentioned this pull request May 6, 2023
Merged
@oliviertassinari
Copy link
Member

oliviertassinari commented May 6, 2023 •
edited

@samuelsycamore

  • These are more places where the unsplash random image is broken. => A good rule of thumb is to always check if more can't be fixed. From my experience, contributors miss > 30% of the time more instances of the same bug. I fixed this in [docs] Fix Material Design templates #37187
  • Don't hesitate to fix the PR titles before merging to match the guideline. This is to keep the commits for the generated changelog clear.

@oliviertassinari oliviertassinari added design: material This is about Material Design, please involve a visual or UX designer in the process package: material-ui Specific to @mui/material labels May 13, 2023
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@navedqb @binh1298
[templates] Image not displayed in blog layout of React template. (mu…
9374cd2 
…i#36991)

Signed-off-by: navedqb <109583873+navedqb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work design: material This is about Material Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image not displayed in blog layout of React Template
5 participants
@navedqb @mui-bot @oliviertassinari @samuelsycamore @zannager