Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix anchor link in customization #37004

Merged
merged 1 commit into from Apr 27, 2023
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 24, 2023

This header was changed in #31997, but it doesn't seem to need to be a h3. h2 seems enough and retains the anchor link.

e.g. of a broken anchor link: https://marmelab.com/react-admin/BooleanField.html#sx-css-api

Screenshot 2023-04-24 at 22 59 53

Noticed in marmelab/react-admin#8857

This header was changed in #31997, but it doesn't seem to need to be a h3, h2 seems enough, and retain the anchor link

Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Apr 24, 2023
@mui-bot
Copy link

mui-bot commented Apr 24, 2023

Netlify deploy preview

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 5c2f9d5

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🤙

@danilo-leal danilo-leal merged commit 2a71b43 into master Apr 27, 2023
26 checks passed
@danilo-leal danilo-leal deleted the oliviertassinari-patch-1 branch April 27, 2023 10:05
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants