Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Allow type alias as well in hooks API docs generation #37034

Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Apr 26, 2023

Addresses #36773 (comment) and #36400 (comment).

The script strictly checked for returnValue and parameters to be of the interface type. I'm not sure why it was added like that. Is there any particular reason? We should allow both type aliases and interfaces.

@ZeeshanTamboli ZeeshanTamboli added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes package: base-ui Specific to @mui/base labels Apr 26, 2023
@mui-bot
Copy link

mui-bot commented Apr 26, 2023

Netlify deploy preview

https://deploy-preview-37034--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 9c12b4c

@ZeeshanTamboli ZeeshanTamboli merged commit eba90da into mui:master Apr 28, 2023
18 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the allow-type-alias-in-hooks-api branch April 28, 2023 07:17
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants