Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Simplify handleChange in SelectInput #37040

Merged
merged 3 commits into from May 4, 2023
Merged

[Select] Simplify handleChange in SelectInput #37040

merged 3 commits into from May 4, 2023

Conversation

ulrichstark
Copy link
Contributor

@ulrichstark ulrichstark commented Apr 26, 2023

Closes #36983
(more context about the motivation behind this change in the linked issue)

@mui-bot
Copy link

mui-bot commented Apr 26, 2023

Netlify deploy preview

https://deploy-preview-37040--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 2dbe2a7

@ulrichstark ulrichstark changed the title simplify handleChange in SelectInput [Select] Simplify handleChange in SelectInput Apr 26, 2023
@michaldudak michaldudak added component: select This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature labels Apr 26, 2023
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's a great first PR!

@ZeeshanTamboli ZeeshanTamboli merged commit 3fe6e91 into mui:master May 4, 2023
18 checks passed
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] Simplify handleChange in SelectInput
4 participants