Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select][TablePagination] Use more descriptive parameter names #37064

Merged
merged 2 commits into from May 9, 2023

Conversation

michaldudak
Copy link
Member

Renamed the instances of the e parameter to more descriptive event, as pointed out in #34158 (comment)

@michaldudak michaldudak added component: select This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base package: joy-ui Specific to @mui/joy component: TablePagination The React component. labels Apr 27, 2023
@mui-bot
Copy link

mui-bot commented Apr 27, 2023

Netlify deploy preview

https://deploy-preview-37064--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 5d4af1b

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 28, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 2, 2023
@michaldudak michaldudak requested review from a team and removed request for siriwatknp May 9, 2023 07:41
@mj12albert mj12albert merged commit 8acb5dd into mui:master May 9, 2023
21 checks passed
@michaldudak michaldudak deleted the remove-shorthands branch May 9, 2023 14:47
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@mnajdova mnajdova changed the title [Select], [TablePagination] Use more descriptive parameter names [Select][TablePagination] Use more descriptive parameter names May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module! component: TablePagination The React component. package: base-ui Specific to @mui/base package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants