[Autocomplete] Support ChipComponent type
#37112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-37112--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
requested changes
May 5, 2023
| @@ -293,4 +293,5 @@ export default function Autocomplete< | |||
| Multiple extends boolean | undefined = false, | |||
| DisableClearable extends boolean | undefined = false, | |||
| FreeSolo extends boolean | undefined = false, | |||
| >(props: AutocompleteProps<T, Multiple, DisableClearable, FreeSolo>): JSX.Element; | |||
| ChipComponent extends React.ElementType = 'div', | |||
There was a problem hiding this comment.
It should be:
Suggested change
| ChipComponent extends React.ElementType = 'div', | |
| ChipComponent extends React.ElementType = ChipTypeMap['defaultComponent'], |
Same in tests
|
It also fixes #33788 |
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33788
before: https://codesandbox.io/s/tender-sun-04j5wj?file=/src/CustomAutocomplete.tsx
after: https://codesandbox.io/s/upbeat-bhaskara-66yqp6?file=/src/CustomAutocomplete.tsx
obeserve typescript error in line 91 in before sandbox, that error is fixed in after sandbox