Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test][joy] js test cases converted to ts #37117

Merged
merged 3 commits into from May 3, 2023
Merged

[test][joy] js test cases converted to ts #37117

merged 3 commits into from May 3, 2023

Conversation

PunitSoniME
Copy link
Contributor

@PunitSoniME PunitSoniME commented May 1, 2023 •
edited by ZeeshanTamboli

Part of #37078

@mui-bot
Copy link

mui-bot commented May 1, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37117--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 1fb29cf

@PunitSoniME PunitSoniME force-pushed the joy-test-cases-from-js-to-ts branch from 6db7ed5 to d6b3b6f Compare May 1, 2023 12:26
@PunitSoniME PunitSoniME mentioned this pull request May 1, 2023
Closed
62 tasks
@zannager zannager added component: Container The React component package: joy-ui Specific to @mui/joy labels May 2, 2023
@zannager zannager requested a review from hbjORbj May 2, 2023 12:04
mauwaz
mauwaz reviewed May 2, 2023
View reviewed changes
packages/mui-joy/src/Link/Link.test.tsx Outdated Show resolved Hide resolved
packages/mui-joy/src/Link/Link.test.tsx Outdated Show resolved Hide resolved
PunitSoniME and others added 2 commits May 3, 2023 16:36
@PunitSoniME
[Container][joy] js test cases converted to ts
6b4e5e1 
resolves #37078

more js converted to ts

prettier executed
@PunitSoniME @mauwaz
Update packages/mui-joy/src/Link/Link.test.tsx
9bb5a9d 
Co-authored-by: Mauwaz N. <79243900+mauwaz@users.noreply.github.com>
Signed-off-by: Punit Soni <punit.soni33@gmail.com>
@PunitSoniME PunitSoniME force-pushed the joy-test-cases-from-js-to-ts branch from ff13b17 to d9b6ddc Compare May 3, 2023 11:06
@PunitSoniME
Update packages/mui-joy/src/Link/Link.test.tsx
1fb29cf 
Co-authored-by: Mauwaz N. <79243900+mauwaz@users.noreply.github.com>
Signed-off-by: Punit Soni <punit.soni33@gmail.com>

build failed fixed

prettier executed
@PunitSoniME PunitSoniME force-pushed the joy-test-cases-from-js-to-ts branch from ae84382 to 1fb29cf Compare May 3, 2023 11:14
mnajdova
mnajdova approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mnajdova mnajdova changed the title [Container][joy] js test cases converted to ts [Container][CssBaseline][FormHelperText][FormLabel][Grid][IconButton][Input][Link][joy] js test cases converted to ts May 3, 2023
@mnajdova mnajdova changed the title [Container][CssBaseline][FormHelperText][FormLabel][Grid][IconButton][Input][Link][joy] js test cases converted to ts [test][joy] js test cases converted to ts May 3, 2023
@mnajdova mnajdova merged commit e758776 into mui:master May 3, 2023
18 checks passed
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@PunitSoniME @binh1298
[test][joy] js test cases converted to ts (mui#37117)
63bc853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauwaz mauwaz mauwaz left review comments

@mnajdova mnajdova mnajdova approved these changes

@hbjORbj hbjORbj Awaiting requested review from hbjORbj

Assignees
No one assigned
Labels
component: Container The React component package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PunitSoniME @mui-bot @mnajdova @mauwaz @zannager