Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Box][Card][MenuList][joy] Turn JS test to TS test #37126

Merged
merged 1 commit into from May 3, 2023
Merged

[Box][Card][MenuList][joy] Turn JS test to TS test #37126

merged 1 commit into from May 3, 2023

Conversation

uuxxx
Copy link
Contributor

@uuxxx uuxxx commented May 1, 2023 •
edited

@mui-bot
Copy link

mui-bot commented May 1, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37126--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 2afe45f

@uuxxx
Copy link
Contributor Author

uuxxx commented May 1, 2023

#37078

@zannager zannager added the package: joy-ui Specific to @mui/joy label May 2, 2023
@zannager zannager requested a review from hbjORbj May 2, 2023 12:03
@hbjORbj hbjORbj changed the title [Box][Card][MenuList][Option][Radio][joy] Turn JS test to TS test [Box][Card][MenuList][joy] Turn JS test to TS test May 3, 2023
@hbjORbj hbjORbj added test component: card This is the name of the generic UI component, not the React module! component: Box The React component. labels May 3, 2023
@hbjORbj hbjORbj mentioned this pull request May 3, 2023
Closed
62 tasks
hbjORbj
hbjORbj approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for your contribution!

@hbjORbj hbjORbj merged commit 086becb into mui:master May 3, 2023
21 of 22 checks passed
@uuxxx uuxxx deleted the switch-js-test-to-ts-2 branch May 3, 2023 16:17
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@uuxxx @binh1298
[Box][Card][MenuList][joy] Turn JS test to TS test (mui#37126)
85171c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees
No one assigned
Labels
component: Box The React component. component: card This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uuxxx @mui-bot @hbjORbj @zannager