Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Radio][IconButton][Checkbox][Option][joy] Switch to TypeScript unit test #37137

Merged
merged 1 commit into from May 3, 2023
Merged

[Radio][IconButton][Checkbox][Option][joy] Switch to TypeScript unit test #37137

merged 1 commit into from May 3, 2023

Conversation

DerTimonius
Copy link
Contributor

Hi everyone, thanks for the continued effort on this great package!

This PR will change a few tests of Joy components from .js to .tsx

  • Radio
  • Checkbox
  • IconButton
  • Option

There were no other changes necessary than renaming them!

see #37078

@DerTimonius DerTimonius mentioned this pull request May 2, 2023
Closed
62 tasks
@mui-bot
Copy link

mui-bot commented May 2, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37137--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against dfab5d1

@hbjORbj hbjORbj changed the title [joy][Radio][IconButton][Checkbox]Change tests to typescript [Radio][IconButton][Checkbox][joy] Switch to TypeScript unit test May 3, 2023
@hbjORbj hbjORbj changed the title [Radio][IconButton][Checkbox][joy] Switch to TypeScript unit test [Radio][IconButton][Checkbox][Option][joy] Switch to TypeScript unit test May 3, 2023
@hbjORbj hbjORbj added test component: checkbox This is the name of the generic UI component, not the React module! component: icon button This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels May 3, 2023
hbjORbj
hbjORbj approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@hbjORbj hbjORbj merged commit ef84d57 into mui:master May 3, 2023
22 of 23 checks passed
@DerTimonius DerTimonius deleted the chore/switch-to-ts-tests branch May 3, 2023 09:41
@DerTimonius
Copy link
Contributor Author

Thanks for the review and merge 🙂

binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@DerTimonius @binh1298
[Radio][IconButton][Checkbox][Option][joy] Switch to TypeScript unit …
98cbd4a 
…test (mui#37137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees
No one assigned
Labels
component: checkbox This is the name of the generic UI component, not the React module! component: icon button This is the name of the generic UI component, not the React module! component: radio This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DerTimonius @mui-bot @hbjORbj