Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Tweak the "Edit this page" button icon #37142

Merged
merged 3 commits into from May 4, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented May 2, 2023

This PR was originally tweaking both the icon of the "Edit this page" button and its positioning of it. But after Gerda's comment bellow, I figured we could benefit from more exploration (which is better done on Figma) and, therefore, am reducing this to just changing the icon ⎯ super simple.

@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label May 2, 2023
@gerdadesign
Copy link
Member

Thanks Danilo! Couple thoughts:

  • I love the addition of the GitHub icon to indicate where you will go. 👏
  • I'm curious if changing the alignment makes it less discoverable, though? Unless that is the intended outcome?
    • We do have a comment button aligned to the right of each section.
  • Additionally, these are all different styles of buttons, so I added in the chart below a potential third option:
    • making the button styles consistent with each other on the page
      • although noting that they're not exactly consistent with the entire system right now
    • keeping the right alignment since they are all categorically related to feedback
      • though I think there is room to explore a wholly different positioning in the overall layout if we wanted to increase the scope of this PR
    • keeping the icon change
Current Solution 1 Solution 2
37142_Before 37142_After 37142_Proposed

LMK what you think about this!

@danilo-leal danilo-leal changed the title [docs] Tweak the "Edit this page" button positioning [docs] Tweak the "Edit this page" button icon May 3, 2023
@danilo-leal
Copy link
Contributor Author

@gerdadesign love it ⎯ thanks for the comment and review! As we've talked about, I've reduced this PR to tweaking just the icon, which seems like a safer move now!

@mui-bot
Copy link

mui-bot commented May 3, 2023

Netlify deploy preview

https://deploy-preview-37142--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against c576a3a

@danilo-leal danilo-leal merged commit 7c385b4 into master May 4, 2023
24 checks passed
@danilo-leal danilo-leal deleted the edit-page-button-position branch May 4, 2023 05:12
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants