Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input][joy] Improve alignment on date fields #37146

Merged
merged 4 commits into from May 9, 2023
Merged

[Input][joy] Improve alignment on date fields #37146

merged 4 commits into from May 9, 2023

Conversation

wewakekumar
Copy link
Contributor

@wewakekumar wewakekumar commented May 3, 2023 •
edited

Issue #37129

Chrome SS:
Screenshot 2023-05-03 at 12 34 51 PM
Edge SS:
Screenshot 2023-05-03 at 12 34 39 PM

@mui-bot
Copy link

mui-bot commented May 3, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37146--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 9e9e22d

@wewakekumar wewakekumar mentioned this pull request May 3, 2023
Closed
2 tasks
@zannager zannager added the component: Grid The React component. label May 3, 2023
@zannager zannager requested a review from siriwatknp May 3, 2023 10:06
@wewakekumar wewakekumar closed this May 4, 2023
@wewakekumar wewakekumar reopened this May 4, 2023
@wewakekumar
Copy link
Contributor Author

@siriwatknp Can you please help me in resolving this test_lint check failure?

@siriwatknp
Copy link
Member

@siriwatknp Can you please help me in resolving this test_lint check failure?

All done! I changed to removing the align-items: stretch instead of using display: grid.

@siriwatknp siriwatknp merged commit e916b0f into mui:master May 9, 2023
21 checks passed
@mnajdova mnajdova changed the title added display as grid [Input][joy] Improve alignment on date fields May 9, 2023
@Studio384
Copy link
Contributor

Studio384 commented May 11, 2023 •
edited

Since this is the only change to Joy that does something with inputs, I'll assume this is causing this, but every time a browser now autofills an input, the background color applied no longer stretches the full input:

image

This works fine with the exact same code in alpha 78.

@siriwatknp
Copy link
Member

siriwatknp commented May 12, 2023 •
edited

Since this is the only change to Joy that does something with inputs, I'll assume this is causing this, but every time a browser now autofills an input, the background color applied no longer stretches the full input:

Thanks for reporting the issue. It is a regression and now I know why I added align-items: stretch 😅.

Can you please open an issue? @Studio384

@Studio384 Studio384 mentioned this pull request May 12, 2023
Closed
2 tasks
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@wewakekumar @binh1298
added display as grid (mui#37146)
3ba753f
@siriwatknp siriwatknp added component: text field This is the name of the generic UI component, not the React module! and removed component: Grid The React component. labels May 25, 2023
@oliviertassinari oliviertassinari added the package: joy-ui Specific to @mui/joy label Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wewakekumar @mui-bot @siriwatknp @Studio384 @oliviertassinari @zannager @wewakekumargetpaz