Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript][base] Fix types of components callbacks parameters #37169

Merged
merged 1 commit into from May 5, 2023

Conversation

michaldudak
Copy link
Member

Fixes the regression introduced in #36677 and restores proper types of callbacks and ref parameters.

Closes #37157

@michaldudak michaldudak added bug 🐛 Something doesn't work typescript package: base-ui Specific to @mui/base labels May 4, 2023
@michaldudak michaldudak requested a review from mnajdova May 4, 2023 20:08
@mui-bot
Copy link

mui-bot commented May 4, 2023

Netlify deploy preview

https://deploy-preview-37169--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against e4b341c

@mnajdova mnajdova merged commit 718334e into mui:master May 5, 2023
21 checks passed
@michaldudak michaldudak deleted the callback-params-types branch May 9, 2023 15:41
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: base-ui Specific to @mui/base typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[base][Button] Button's mouse event is of type any in 5.12.3
3 participants