Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AppBar] Fix component type #37172

Merged
merged 1 commit into from May 9, 2023
Merged

[AppBar] Fix component type #37172

merged 1 commit into from May 9, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented May 5, 2023 •
edited

before: https://codesandbox.io/s/gifted-bash-gsto2d?file=/demo.tsx:0-226

after: https://codesandbox.io/s/amazing-cori-xt0uds

Steps to reproduce

  1. go to before sandbox
  2. hover on the event argument on onClick function.
  3. notice the type of event is set to React.MouseEvent<HTMLDivElement, MouseEvent> where type of event should be React.MouseEvent<HTMLAnchorElement, MouseEvent> as component='a' is set to AppBar

@sai6855 sai6855 added bug 🐛 Something doesn't work component: app bar This is the name of the generic UI component, not the React module! typescript package: material-ui Specific to @mui/material labels May 5, 2023
@mui-bot
Copy link

mui-bot commented May 5, 2023 •
edited

Netlify deploy preview

https://deploy-preview-37172--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 6527a07

@sai6855
Copy link
Contributor Author

sai6855 commented May 5, 2023

changes in this PR is similar to changes done in #37111

@sai6855 sai6855 requested review from mj12albert and removed request for mj12albert May 5, 2023 04:44
mj12albert
mj12albert approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ~ 👍

@mj12albert mj12albert merged commit 609e2a6 into mui:master May 9, 2023
21 of 22 checks passed
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
@sai6855 @binh1298
[AppBar] Fix component type (mui#37172)
f4df2bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj12albert mj12albert mj12albert approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: app bar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sai6855 @mui-bot @mj12albert