-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete][joy] Fix Autocomplete and Modal components to work together #37515
[Autocomplete][joy] Fix Autocomplete and Modal components to work together #37515
Conversation
Netlify deploy previewhttps://deploy-preview-37515--material-ui.netlify.app/ Bundle size report |
@siriwatknp can you please check this. |
@saikathalderr Thanks for the fix. I think it is partially done because by adding For example, you have a header with a sticky position ( I think the solution is still using |
…oy-ui-autocomplete-and-model-does-not-work-properly-together
@@ -500,7 +501,6 @@ const Select = React.forwardRef(function Select<TValue extends {}>( | |||
additionalProps: { | |||
ref: listboxRef, | |||
anchorEl, | |||
disablePortal: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall why disablePortal
is used here but I think it should not have it true
by default to be consistent with other popup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for initiating the fix!
Fixed In Joy UI Autocomplete and Modal do not work properly together.
closes #37501
After:
Screen.Recording.2566-06-22.at.10.59.41.mov
https://codesandbox.io/s/joy-cra-ts-forked-kcds54?file=/src/App.tsx