[docs-infra] Fix layout shift ad #37694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 馃悰
Netlify deploy previewhttps://deploy-preview-37694--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
fix-layout-shift-ad
branch
3 times, most recently
from
6d3ae6c
to
a409062
Compare
Comment on lines
-221
to
+222
| m: (theme) => theme.spacing(4, 0, 3), | ||
| mt: 4, | ||
| mb: 3, |
| @@ -111,7 +111,7 @@ class AdErrorBoundary extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| function Ad() { | |||
| export default function Ad() { | |||
| @@ -47,7 +47,7 @@ const StyledAppContainer = styled(AppContainer, { | |||
| ...(!disableAd && { | |||
| ...(!hasTabs && { | |||
| '&& .description': { | |||
| marginBottom: 198, | |||
| marginBottom: 4 * 10 + 3 * 10 + 126, | |||
Comment on lines
88
to
92
| // TODO, remove this prop, the layout should be retained as much as possible | ||
| // between pages, to improve performance, and retain UI states, e.g. scroll | ||
| disableLayout = false, |
There was a problem hiding this comment.
Clean up, I don't understand how the creation of AppLayoutDocsWithoutAppFrame.js would be the right thing to do.
| padding: `${theme.spacing(1.5)} ${theme.spacing(1.5)} ${theme.spacing( | ||
| 1.5, | ||
| )} calc(${theme.spacing(1.5)} + 130px)`, | ||
| padding: '12px 12px 12px calc(12px + 130px)', |
There was a problem hiding this comment.
Retain the same style values, after changing from spacing.unit 8px to 10px.
| }, [theme]); | ||
|
|
||
| // TODO: remove MdThemeProvider, top level layout should render the default theme. |
There was a problem hiding this comment.
I think that this is really important, we want to show the default look in the docs.
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
fix-layout-shift-ad
branch
2 times, most recently
from
66cbb05
to
153b85a
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
force-pushed
the
fix-layout-shift-ad
branch
from
153b85a
to
01e10ff
Compare
oliviertassinari
force-pushed
the
fix-layout-shift-ad
branch
from
01e10ff
to
002fa21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken at one point, the UX is not great, there are 2 layout shifts:
Screen.Recording.2023-06-25.at.00.03.14.mov
https://mui.com/joy-ui/getting-started/overview/
It's so smooth now 馃槍 https://deploy-preview-37694--material-ui.netlify.app/joy-ui/getting-started/. I think that it matters because we want the ad to blend into the content, the less it's distinguishable, the less developers will avoid it.