[docs-infra] Improve demos toolbar #37762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
design
Netlify deploy previewhttps://deploy-preview-37762--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
polish-display-demo
branch
from
36b3c77
to
ab0f5d4
Compare
| { | ||
| display: 'none', | ||
| border: `1px solid ${(theme.vars || theme).palette.divider}`, | ||
| marginTop: -1, | ||
| marginTop: demoOptions.bg === 'inline' ? 8 : -1, |
There was a problem hiding this comment.
The negative margin when the bg is inline is strange, see https://mui.com/x/react-data-grid/#mit-version and https://mui.com/x/react-date-pickers/shortcuts/#customization as two examples.
Comment on lines
-285
to
-287
| ...(hiddenToolbar && { | ||
| paddingTop: theme.spacing(2), | ||
| }), |
There was a problem hiding this comment.
This style seem irrelevant
| @@ -233,7 +230,7 @@ const DemoRootMaterial = styled('div', { | |||
| }), | |||
| /* Prepare the background to display an inner elevation. */ | |||
| ...(bg === true && { | |||
| padding: theme.spacing(4), | |||
| padding: theme.spacing(3), | |||
| @@ -210,7 +210,7 @@ const DemoRootMaterial = styled('div', { | |||
| display: 'flex', | |||
| justifyContent: 'center', | |||
| [theme.breakpoints.up('sm')]: { | |||
| borderRadius: '12px 12px 0 0', | |||
| borderRadius: hiddenToolbar ? 12 : '12px 12px 0 0', | |||
There was a problem hiding this comment.
Fix border-radius at the footer of https://mui.com/material-ui/react-grid/#interactive
Comment on lines
-222
to
-224
| ...(hiddenToolbar && { | ||
| paddingTop: theme.spacing(1), | ||
| }), |
There was a problem hiding this comment.
This style seem irrelevant
danilo-leal
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed small bugs with the demo, so I created a playground to debug and fixed a few instances.
Preview: https://deploy-preview-37762--material-ui.netlify.app/experiments/docs/demos/