Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typography] Rename Typography -> Text #37951

Open
2 tasks done
ChristopherTrimboli opened this issue Jul 13, 2023 · 7 comments
Open
2 tasks done

[Typography] Rename Typography -> Text #37951

ChristopherTrimboli opened this issue Jul 13, 2023 · 7 comments
Labels
component: Typography The React component. package: joy-ui Specific to @mui/joy package: material-ui Specific to @mui/material package: system Specific to @mui/system waiting for 👍 Waiting for upvotes

Comments

@ChristopherTrimboli
Copy link

ChristopherTrimboli commented Jul 13, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

<Typography /> is a complex word to type and I feel <Text /> is simpler and easier.
"Text" is also probably more internationally known then "Typography". Bit of a fancy word in English.
Characters of code would be reduced and manual coding we do use <Typography /> a lot when typing, would be nice to cut the word count by 60% and just use <Text />.

Examples 🌈

<Typography /> -> <Text />

Motivation 🔦

Make it easier for devs to code Material UI.

@ChristopherTrimboli ChristopherTrimboli added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jul 13, 2023
@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Jul 14, 2023
@oliviertassinari
Copy link
Member

Related:

Screenshot 2023-07-15 at 00 24 49

@oliviertassinari oliviertassinari added component: Typography The React component. package: system Specific to @mui/system package: material-ui Specific to @mui/material package: joy-ui Specific to @mui/joy labels Jul 14, 2023
@mj12albert
Copy link
Member

mj12albert commented Jul 15, 2023

I think Header + Text is a good idea! CC @siriwatknp

Some benchmarks:

@mj12albert mj12albert added waiting for 👍 Waiting for upvotes and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 15, 2023
@mj12albert mj12albert changed the title change Typography -> Text [Typography] Rename Typography -> Text Jul 15, 2023
@mwskwong
Copy link
Contributor

mwskwong commented Jul 16, 2023

I would name it Heading instead of Header instead. Header usually has the same meaning as app bar.

@ChristopherTrimboli
Copy link
Author

I think Heading is almost as bad as Typography, I would keep as just <Text /> with component="h5" for headings.

@arobert93
Copy link

arobert93 commented Aug 2, 2023

Can we have something similar to Chakra typography (Heading & Text)?

I find the new Joy Typography update in beta.0 extremely confusing. It is not clear enough why there is only level h1 to h4, then title-[size] goes from sm to lg but body-[size] goes from xs to xl.

@zanivan
Copy link
Contributor

zanivan commented Aug 2, 2023

Can we have something similar to Chakra typography (Heading & Text)?
I find the new Joy Typography update in beta.0 extremely confusing. It is not clear enough why there is only level h1 to h4, then title-[size] goes from sm to lg but body-[size] goes from xs to xl.

Hey @arobert93, thanks for the feedback! ✨
There is definitely room for improvement there—I've gone ahead and opened an issue #38290 that fits better with the discussion regarding Joy UI Typography levels, please, feel free to elaborate on what would be the best approach for this matter there.

@MonstraG
Copy link
Contributor

MonstraG commented Aug 2, 2023

I just wanna mention that there happens to be native <text/> element, which is an svg element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Typography The React component. package: joy-ui Specific to @mui/joy package: material-ui Specific to @mui/material package: system Specific to @mui/system waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

7 participants