Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FocusTrap] Finish rename from TrapFocus #38902

Open
oliviertassinari opened this issue Sep 10, 2023 · 3 comments
Open

[FocusTrap] Finish rename from TrapFocus #38902

oliviertassinari opened this issue Sep 10, 2023 · 3 comments
Labels
bug 馃悰 Something doesn't work component: FocusTrap The React component. MUI X regression A bug, but worse

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 10, 2023 •
edited

Steps to reproduce 馃暪

Link to live example:

Steps:

  1. https://github.com/search?q=repo%3Amui%2Fmui-x+TrapFocus&type=code
  2. https://github.com/search?q=repo%3Amui%2Fmaterial-ui+TrapFocus&type=code

Current behavior 馃槸

FocusTrap still has references as TrapFocus in MUI Core and MUI X codebase.

Expected behavior 馃

We finished the rename we started in #34216.

I labeled this as a regression as it used to be a consistent terminology. It now feels more confusing than before #32364 (comment) as both variations exists.

Context 馃敠

Your environment 馃寧

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@oliviertassinari oliviertassinari added bug 馃悰 Something doesn't work component: FocusTrap The React component. regression A bug, but worse labels Sep 10, 2023
@oliviertassinari oliviertassinari changed the title [FocusTrap] Finish rename to TrapFocus [FocusTrap] Finish rename from TrapFocus Sep 10, 2023
oliviertassinari added a commit to mui/mui-x that referenced this issue Sep 10, 2023
@oliviertassinari
[core] TrapFocus was renamed to FocusTrap
1734b59 
mui/material-ui#38902
@oliviertassinari oliviertassinari mentioned this issue Sep 10, 2023
Closed
2 tasks
@shroommu
Copy link

I'll take this on :)

@shroommu shroommu mentioned this issue Sep 16, 2023
Closed
@pawel-schmidt
Copy link

@shroommu are you still working on that? If yes, may it be assigned to you? If not - I can take over 馃檶

@vineetjk
Copy link
Contributor

vineetjk commented Oct 9, 2023

@shroommu are you still working on this? if not - I can take, Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 馃悰 Something doesn't work component: FocusTrap The React component. MUI X regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pawel-schmidt @oliviertassinari @shroommu @vineetjk