Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][FilledInput] Fix slot props deepmerge order #38922

Merged

Conversation

dhaub-exelixis
Copy link
Contributor

fixes: #38489

Changes priority of deepmerge function call for FilledInput to avoid crashing with a circular ownerState object.

@danilo-leal danilo-leal changed the title fixes autocomplete filled input deepmerge error [material-ui][Autocomplete] Fix filled input deepmerge error Sep 11, 2023
@dhaub-exelixis dhaub-exelixis changed the title [material-ui][Autocomplete] Fix filled input deepmerge error [Material] Fixes autocomplete filled input deepmerge error Sep 11, 2023
@danilo-leal danilo-leal added package: material-ui Specific to @mui/material component: autocomplete This is the name of the generic UI component, not the React module! labels Sep 11, 2023
@danilo-leal danilo-leal changed the title [Material] Fixes autocomplete filled input deepmerge error [material-ui][Autocomplete] Fix filled input deepmerge error Sep 11, 2023
@mui-bot
Copy link

mui-bot commented Sep 11, 2023

Netlify deploy preview

https://deploy-preview-38922--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against fc7f7b0

@michaldudak
Copy link
Member

Could you please add a test that verifies the changed behavior?

@michaldudak michaldudak added the PR: needs test The pull request can't be merged label Sep 18, 2023
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've added the missing test.

@mnajdova mnajdova added Port to v6.x and removed PR: needs test The pull request can't be merged labels Nov 14, 2023
@mnajdova mnajdova changed the title [material-ui][Autocomplete] Fix filled input deepmerge error [material-ui][FilledInput] Fix slot props deepmerge order Nov 14, 2023
@mnajdova mnajdova merged commit e049e1b into mui:master Nov 14, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
5 participants