[core] Remove unused use client #38967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-38967--material-ui.netlify.app/ Bundle size report |
1 task
|
I have found a case where we need to remove the "use client": #39010. |
|
@mj12albert Are we good to move this forward? |
mj12albert
approved these changes
Oct 9, 2023
@oliviertassinari 👍 I tried removing it from everything (in Base) but some components still have issues, going forward we can investigate the root cause on a component basis! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test #38955 (comment) out.
As far as I can see it, it continues to work: https://stackblitz.com/edit/github-9lau57?file=package.json,src%2Fapp%2Flayout.tsx,src%2Fapp%2Fpage.tsx,next.config.js
Help with #34905. I think we need to remove "use client" from the index so we can have room to mix server and client components from our npm packages.