Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][system] Revise the Box page #39159

Merged
merged 9 commits into from
Oct 19, 2023
Merged

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Sep 25, 2023

Closes #35699

This PR revises the Box page on the MUI System docs and adds a Box page to the Joy UI docs, but just to refer back to the original MUI System docs to avoid content duplication and maintenance cost (same with Material UI).

馃憠 https://deploy-preview-39159--material-ui.netlify.app/system/react-box/
馃憠 https://deploy-preview-39159--material-ui.netlify.app/joy-ui/react-box/

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: Box The React component. package: joy-ui Specific to @mui/joy labels Sep 25, 2023
@danilo-leal danilo-leal self-assigned this Sep 25, 2023
@mui-bot
Copy link

mui-bot commented Sep 25, 2023

@danilo-leal
Copy link
Contributor Author

@samuelsycamore Feel free to chime in here whenever possible, even though it's in draft. We can make progress with the copy and add the demos later!

@danilo-leal danilo-leal changed the title [docs][joy-ui] Add the Box page [docs][system] Revise the Box page Oct 13, 2023
@danilo-leal danilo-leal added package: system Specific to @mui/system and removed package: joy-ui Specific to @mui/joy labels Oct 13, 2023
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first pass - I think this a great direction for this info! I'm happy to come back around and do another pass on the existing content in more detail.

docs/data/joy/components/box/box.md Outdated Show resolved Hide resolved
docs/data/material/components/box/box.md Outdated Show resolved Hide resolved
docs/data/system/components/box/box.md Outdated Show resolved Hide resolved
docs/data/system/components/box/box.md Outdated Show resolved Hide resolved
docs/data/system/components/box/box.md Outdated Show resolved Hide resolved
docs/data/system/components/box/box.md Outdated Show resolved Hide resolved
docs/data/system/components/box/box.md Outdated Show resolved Hide resolved
docs/data/material/components/box/box.md Outdated Show resolved Hide resolved
docs/data/system/components/box/box.md Outdated Show resolved Hide resolved
docs/data/system/components/box/box.md Outdated Show resolved Hide resolved
docs/data/system/components/box/box.md Outdated Show resolved Hide resolved
docs/data/joy/components/box/box.md Outdated Show resolved Hide resolved
Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this as always @danilo-leal !

@danilo-leal danilo-leal marked this pull request as ready for review October 19, 2023 15:15
@danilo-leal danilo-leal merged commit 4ea27e4 into mui:master Oct 19, 2023
22 checks passed
@danilo-leal danilo-leal deleted the add-box-page-joy branch October 19, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Box The React component. docs Improvements or additions to the documentation package: system Specific to @mui/system
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

[docs][joy-ui] Add documentation for Box component in the sidebar
3 participants