[docs] Revise the Contributing Guide #39190
Merged
+133
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mapache-salvaje
commented
Sep 27, 2023
•
mapache-salvaje
commented
- Line breaks after each sentence for simpler line-by-line editing
- "Pull Request" —> "pull request" or "PR" - not sure why it was capitalized throughout most of this doc
- Sentence case for all headers
- Parallel structure for list items
- Rearranged steps for adding demos to the docs - it makes more sense to me to build the demo first, then add a section to the docs about it
- Copyediting everywhere, but especially "Your first pull request" section
- Grammar, style, typo fixes
Netlify deploy previewhttps://deploy-preview-39190--material-ui.netlify.app/ Bundle size report |
danilo-leal
reviewed
Sep 27, 2023
1 task
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
danilo-leal
approved these changes
Sep 28, 2023
mbrookes
reviewed
Oct 2, 2023
mbrookes
reviewed
Oct 2, 2023
mbrookes
reviewed
Oct 2, 2023
2 tasks
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
mapache-salvaje
changed the title
Co-authored-by: Matt <github@nospam.33m.co> Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
|
In place of the translations section, I added a line to the "Wide spectrum of contributions" section suggesting that folks start by opening an issue if they have an idea for an improvement. |
mapache-salvaje
requested review from
mbrookes and
danilo-leal
and removed request for
mnajdova
danilo-leal
approved these changes
Oct 10, 2023
mbrookes
approved these changes
Oct 12, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Matt <github@nospam.33m.co>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Matt <github@nospam.33m.co>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Co-authored-by: Matt <github@nospam.33m.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.