Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Prevent docs crash #39214

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Sep 29, 2023

I just got the docs crashing. After some navigation in the source code of the page, it appears it's the feedback cookies that have incorrect JSON format.

image

This token is used to save user feedback on pages. Since it's not super important, I just added a try/catch.

@alexfauquette alexfauquette added the scope: docs-infra Specific to the docs-infra product label Sep 29, 2023
@alexfauquette alexfauquette requested a review from a team September 29, 2023 10:14
@mui-bot
Copy link

mui-bot commented Sep 29, 2023

Netlify deploy preview

https://deploy-preview-39214--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 04eb3b2

@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Oct 22, 2023
@alexfauquette alexfauquette merged commit a731e86 into mui:master Oct 23, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants