Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-next][Snackbar] copy files to mui-material-next #39232

Merged
merged 1 commit into from
Oct 18, 2023
Merged

[material-next][Snackbar] copy files to mui-material-next #39232

merged 1 commit into from
Oct 18, 2023

Conversation

Best-Sardar
Copy link
Contributor

related to: #39207

In this change, only the Snackbar files were moved to mui-material-next and their imports were adjusted.

@mui-bot
Copy link

mui-bot commented Sep 30, 2023 •
edited

Netlify deploy preview

https://deploy-preview-39232--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 4d8a492

@Best-Sardar Best-Sardar force-pushed the copy-material-you-snackbar-component branch from df5527b to 4d8a492 Compare October 1, 2023 20:08
@zannager zannager added the component: snackbar This is the name of the generic UI component, not the React module! label Oct 2, 2023
@DiegoAndai
Copy link
Member

Hey @Best-Sardar! thanks for taking this component as well 😊
I have this PR in mind, but I would prefer to merge the Divider work before moving on to another one. Is that OK with you? 😊

@Best-Sardar
Copy link
Contributor Author

Hi @DiegoAndai,
Considering that there might be interruptions in the progress of the divider, if it's possible for you, I can work on this matter.
I acknowledge that I don't have a strong command of the MUI codebase, but I will make every effort to minimize the involvement of the core MUI team members.
I have no problem with pausing this issue, and I simply wanted to help expedite the implementation.

We can proceed in whichever way you deem appropriate.

@DiegoAndai DiegoAndai mentioned this pull request Oct 16, 2023
Merged
1 task
@DiegoAndai DiegoAndai changed the title [Snackbar][Material You] copy snackbar files to mui-material-next [material-next][Snackbar] copy files to mui-material-next Oct 18, 2023
@DiegoAndai DiegoAndai added the package: material-ui Specific to @mui/material label Oct 18, 2023
@DiegoAndai DiegoAndai mentioned this pull request Oct 18, 2023
Open
8 tasks
@DiegoAndai DiegoAndai merged commit 797693f into mui:master Oct 18, 2023
21 checks passed
@DiegoAndai
Copy link
Member

Hey @Best-Sardar! I merged this PR, and we're ready to continue working on the Snackbar 😊
Let me know if you need help with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: snackbar This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Best-Sardar @mui-bot @DiegoAndai @zannager