[material-ui][TablePagination] Implement slotProps pattern for the actions and the select slots

[anle9650]

Resolves #39336

• I have followed (at least) the PR section of the contributing guide.

[mui-bot]

Netlify deploy preview

https://deploy-preview-39353--material-ui.netlify.app/

@material-ui/core: parsed: +0.08% , gzip: +0.08%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against fedbde3

[cjenkscybercom]

Awesome! Could this also disable the page size dropdown as well?
(#39336)

[anle9650]

^ Done!

[cjenkscybercom]

Awesome, thank you!

[DiegoAndai]

Hey @anle9650! Thanks for working on this 😊

I think it's a good addition 🎉

May I ask you to also add the firstIconButtonProps and lastIconButtonProps for completion? That way, we also support disabling those specifically.

[anle9650]

@DiegoAndai just added those!

[DiegoAndai]

Thanks @anle9650!

I've discussed this with some members of the team, and we would prefer to implement the slotProps prop instead of adding firstIconButtonProps and lastIconButtonProps, I'm sorry for not bringing this up before. It would be a little more work, but the slotProps pattern is the standard we're trying to introduce (see this Slider slotProps example).

We would have to add the slotProps prop with keys firstIconButton, lastIconButton, nextIconButton, previousIconButton, and select. Using the first icon as an example:

• slotProps = { firstIconButton: someProps } would be equivalent to firstIconButtonProps = {someProps}
• slotProps.firstIconButton should override firstIconButtonProps
• We would add a deprecation message to firstIconButtonProps: This prop is an alias for slotProps.firstIconButton and will be overridden by it if both are used (see this Popover PaperProps deprecation message example)

Do you have time to work on it? I can provide guidance for it 😊

Also, I want to bring @cherniavskii into the conversation as the DataGrid owner, as these API changes would impact the DataGrid's pagination prop:

• What do you think about adding the global disabled prop to the pagination?
• What do you think about introducing slotProps and deprecating the *IconButtonProps props?

[cherniavskii]

Hi @DiegoAndai,
Looks good to me!
The Data Grid doesn't use the props you proposed to deprecate, and it's backward compatible anyway 👍🏻

[anle9650]

@DiegoAndai just made those changes!

[DiegoAndai]

Nice @anle9650! thanks

I think we're only missing a couple details, almost there 🚀

[DiegoAndai]

@anle9650 nice work! This is ready to merge from my perspective. Because I helped guide the solution, I'll ask for a second review from @mnajdova 🙌🏼

[DiegoAndai]

Hey @anle9650! thanks for keeping working on this

I added a couple more comments/questions to ensure that we don't break developer's apps with this change 😊

[mnajdova]

LGTM, thanks for the effort!