[joy-ui][typography] Update docs after lineHeight changes #39366
+174
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
docs
Netlify deploy previewBundle size report |
danilo-leal
reviewed
Oct 11, 2023
| @@ -41,8 +41,6 @@ The `title-*` and `body-*` are commonly used in components. | |||
|
|
|||
| We recommend to combine the title and body with the same or lower size when using them together. For example, `title-lg` and `body-lg` or `title-md` and `body-sm`. | |||
There was a problem hiding this comment.
Suggested change
| We recommend to combine the title and body with the same or lower size when using them together. For example, `title-lg` and `body-lg` or `title-md` and `body-sm`. | |
| Aside from the heading typographic levels, the Typography component provides `title-*` and `body-*` type levels. | |
| To ensure a good UI balance and information hierarchy, we recommend combining them using the same size or a lower one. | |
| For example, using `title-lg` with `body-lg` or `title-md` with `body-sm`. |
I know you haven't touched this, but it's a good opportunity to revise this small paragraph a bit. I can't get the previous sentence (i.e., "The title-* and body-* are...") in the suggestion, but I'm considering it for it! It's a tricky sentence — @samuelsycamore might be able to shed some more light!
|
Those icons are gone, is it expected? The image in the description still contain icons. |
As @danilo-leal suggested here, since we won't have line-heights matching icons, I chose to have them removed to simplify the demo. The PR description is now updated 😉 |
danilo-leal
approved these changes
Oct 12, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the 'Title and body' demo on the Typography docs page. After changes made on #38462, the lineHeight from Typography no longer fits with SVG icons, so I tweaked the demo to make sense with the current version.
👉 https://deploy-preview-39366--material-ui.netlify.app/joy-ui/react-typography/#title-and-body