Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Adjust design kits-related content #39367

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Oct 9, 2023

Sorry, something went wrong.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material package: joy-ui Specific to @mui/joy labels Oct 9, 2023
@danilo-leal danilo-leal requested a review from zanivan October 9, 2023 22:33
@danilo-leal danilo-leal self-assigned this Oct 9, 2023
@mui-bot
Copy link

mui-bot commented Oct 9, 2023

Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement, the Material UI page feels way cleaner and sleek 🚀

@danilo-leal
Copy link
Contributor Author

One bad thing about a page's content being short like it is now on the Material UI is that this happens 😅
I'm slightly hesitant to mess with the app layout component CSS and then mess other pages up... 😶

Screen Shot 2023-10-10 at 20 12 14

@danilo-leal
Copy link
Contributor Author

@alexfauquette I wonder if you have any insights about the point above ☝️

@alexfauquette
Copy link
Member

Adding a minHeight: '100vh' here should do the job.

I don't see a drawback since for most pages the height will be much larger than the view height. But I could be missing something

@danilo-leal danilo-leal merged commit 1a5ebfe into mui:master Oct 13, 2023
@danilo-leal danilo-leal deleted the docs-design-resources branch October 13, 2023 11:48
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 17, 2023
Comment on lines -11 to +9
### Figma

[Material UI for Figma](https://mui.com/store/items/figma-react/?utm_source=docs&utm_medium=referral&utm_campaign=installation-figma): a comprehensive component inventory for Figma, including over 1,500 unique elements that cover the full range of states and variations of each component.

### Adobe XD

[Material UI for Adobe XD](https://mui.com/store/items/adobe-xd-react/?utm_source=docs&utm_medium=referral&utm_campaign=installation-adobe-xd): a comprehensive component inventory for Adobe XD, including over 1,500 unique elements that cover the full range of states and variations of each component.

### Sketch

[Material UI for Sketch](https://mui.com/store/items/sketch-react/?utm_source=docs&utm_medium=referral&utm_campaign=installation-sketch): a comprehensive component inventory for Sketch, including over 1,500 unique elements that cover the full range of states and variations of each component, as well as 1,000+ icons in five themes.
{{"component": "modules/components/MaterialUIDesignResources.js"}}
Copy link
Member

@oliviertassinari oliviertassinari Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leads to an Algolia search experience regression. Searching for "Figma" in the docs doesn't yield results anymore.

Fixing this in #39956.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants