-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Open the Design Engineer - xGrid
role
#39375
Conversation
Design Engineer - xGrid
role
Netlify deploy previewhttps://deploy-preview-39375--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing 💙 I'm excited to meet the next fellow design engineer
I left some comments about the definition of the role, I feel like we can clarify/add a few things. Hoping to spiral a conversation around this topic so we can update this notion page after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited about this role! 🎉 Overall, though, before getting too deep with the review, I think we should follow the structure @samuelsycamore is playing with on his recent rewrite of a Dev Advocate role — #39210. I think what he's written there (e.g., "The product", "The culture", "The company", etc.) explains super well + using the required vs. nice to have structure as opposed to "the good" and "the worst" parts (for which, even though I get the intent for transparency with mentioning "the worst" parts, I think it's weird calling that out this way... seems the type of stuff that'd fit in the "The culture" section).
Edit: see #39386
FYI: @oliviertassinari and I were just talking about updating the general hiring template with the revisions I've made in this PR. There is one more section I'm planning to add today—repurposing the "Why we're hiring" section to provide more context to the applicant. But I'd love to see that format transferred to the other roles! |
To rebase on #39386 once merged. |
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Done. If this description is accepted I'll update the one in Ashby to match this, publish the role and update the link to Ashby in this PR before merging it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo, sweet! Excited to see how this one's shaping up! 🤘
- **Bridge the gap between design and engineering**. | ||
You will closely work with designers and engineers, and act as a communication conduit between the two roles to ensure efficient workflows and shared understanding of goals. | ||
|
||
### The best parts of this job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm honestly up for removing both the "The best" and "The worst" sections here. The "the best" part doesn't add a lot; most of it has already been said one way or another. And the "the worst" part is probably better shared during the interviews?
Or at least, not necessarily framed as "the worst" — they are more like any startup challenge (i.e., context switching, speed vs. quality, complexity, novel problem, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm up for a leaner description in general. I don't think we need to oversell ourselves. If we were an unknown company or project then yes but in our case I don't think it's needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the "selling" part, do we need to say anything else here? I think the sections above (product, company, culture) sort of already cover these topics.
Also, adding some more thoughts to "the worst part", I appreciate the transparency in saying things like "it's a complex code, be aware!", "you might get overwhelmed by the OSS repo! are you sure?" etc. But I think there might be a better way to frame them not as "the worst" but more like... challenges? Part of the gig, you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with rephrasing the 'worst' here 🤔 It's great that we are being transparent, but IMO challenges are not necessarily something to run from or paint as entirely negative. We can rename this section to 'challenges you might face', WDYT?
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love how this is turning out! 💙
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
@danilo-leal @noraleonte if the description looks good I would propose to move forward and open the role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 Excited for this 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last one, just fine-tuning the "The best" vs. "The worst" part sections — as we were discussing in that thread before. Other than this, I think it's looking great! Tentatively approving it 🤙 Great work, everybody!
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Danail Hadjiatanasov <hadjiatanasov@gmail.com>
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
ToDo:
Preview: https://deploy-preview-39375--material-ui.netlify.app/careers/design-engineer-x-grid/